Conversation
gingyx
changed the title
tdonohue
added
usability
component: submission
1 APPROVAL
tdonohue
left a comment
tdonohue
left a comment
There was a problem hiding this comment.
@gingyx : I tried this out today on a Chrome browser, and the display looks different for me. Here's what I see
As you can see, it looks more cluttered. I tried doing a hard reload (Ctrl + reload in browser) to make sure I didn't have any older styles cached, but that didn't make a difference.
Does this still work properly for you? All I did was change the default "dc.type" input field to use <input-type value-pairs-name="common_types">list</input-type>, and this is the display that resulted from this PR.
Let me know if I made a mistake in testing this, or something.
github-project-automation
Bot
moved this from 🙋 Needs Reviewers Assigned
to 👀 Under Review
in DSpace 9.0 Release
|
@gingyx : Quick note. It looks like your latest update resulted in unit test failures (spec failures). It's likely you need to update the |
gingyx
force-pushed
the
w2p-127705_cleanup-input-form-spacing_contribute-main
branch
from
cf8fa1a to
46a8953
Compare
|
@tdonohue Sorry about that, the tests are fixed now. |
github-project-automation
Bot
moved this from 👀 Under Review
to 👍 Reviewer Approved
in DSpace 9.0 Release
github-project-automation
Bot
moved this from 👍 Reviewer Approved
to ✅ Done
in DSpace 9.0 Release
2 participants
References
Description
This PR reduces margins on input fields for a more streamlined submission form design.
Instructions for Reviewers
List of changes in this PR:
ds-dynamic-form-control-container.component.scssto reduce bottom margins on all input field labels.dynamic-list.component.htmlto remove left margins from checkbox and radio button lists.BEFORE
AFTER
How to test or review the PR:
Checklist
My PR is created against the
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
My PR passes ESLint validation using
npm run lintMy PR doesn't introduce circular dependencies (verified via
npm run check-circ-deps)My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
My PR aligns with Accessibility guidelines if it makes changes to the user interface.
My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
If my PR includes new libraries/dependencies (in
package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
If my PR fixes an issue ticket, I've linked them together.